lab/sx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ir): serialize enum-literal global initializers (issue 0082)

Browse Source 
A module-global initialized with an enum literal silently zero-initialized
to the first tag (`chosen : Color = .green` read back as `.red`), and an
enum tag inside a global array/struct was rejected as non-constant. The
constant serializer had no enum-literal arm.

Add `Lowering.constEnumLiteral`: serialize an enum literal to a
`ConstantValue.int` holding the variant's tag value, resolved against the
destination enum type and respecting explicit variant values; the global's
type drives the backing width at emit time. Wired into `globalInitValue`
(scalar global) and `constExprValue` (array element / struct field / nested
aggregate). A non-enum destination or unknown variant is diagnosed loudly,
never silently zero-initialized. The compiler-injected OS/ARCH globals now
serialize to their real `.unknown` tag (6 / 4); runtime reads are unchanged
(they resolve through comptime_constants), so only the static initializer in
the pinned .ir snapshots changes.

Remove the silent `func_ref => orelse LLVMConstNull` fallbacks in the LLVM
constant emitters: aggregate func_ref leaves carry a `require_resolved` flag
(transient null in Pass 0, loud diagnostic if still unresolved in the
Pass-1.5 re-emit), a top-level func_ref global is resolved in
initVtableGlobals, and the comptime (#run) path bails loudly instead of
emitting a null function pointer.

Regression: examples/0139-types-global-enum-literal-init.sx (scalar, array,
struct field, explicit-value enum u16 stride, struct-array with enum field);
negative: examples/1127-diagnostics-global-enum-literal-bad-variant.sx.
Mark issue 0082 RESOLVED.
This commit is contained in:
agra
2026-06-04 04:52:42 +03:00
parent d680b320f4
commit 263333bd26
21 changed files with 294 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
examples/expected/0031-basic-local-fn-return.ir
View File

@@ -1,6 +1,6 @@
@OS = internal global i64 0
@ARCH = internal global i64 0
@OS = internal global i64 6
@ARCH = internal global i64 4
@POINTER_SIZE = internal global i64 8
@__sx_default_context = internal global { { ptr, ptr, ptr }, ptr } { { ptr, ptr, ptr } { ptr null, ptr @__thunk_CAllocator_Allocator_alloc, ptr @__thunk_CAllocator_Allocator_dealloc }, ptr null }
@str = private unnamed_addr constant [2 x i8] c"0\00", align 1

4
examples/expected/0032-basic-ufcs-return-type.ir
View File

@@ -1,6 +1,6 @@
@OS = internal global i64 0
@ARCH = internal global i64 0
@OS = internal global i64 6
@ARCH = internal global i64 4
@POINTER_SIZE = internal global i64 8
@__sx_default_context = internal global { { ptr, ptr, ptr }, ptr } { { ptr, ptr, ptr } { ptr null, ptr @__thunk_CAllocator_Allocator_alloc, ptr @__thunk_CAllocator_Allocator_dealloc }, ptr null }
@str = private unnamed_addr constant [2 x i8] c"0\00", align 1

1
examples/expected/0139-types-global-enum-literal-init.exit Normal file
View File

@@ -0,0 +1 @@
0

1
examples/expected/0139-types-global-enum-literal-init.stderr Normal file
View File

@@ -0,0 +1 @@

4
examples/expected/0139-types-global-enum-literal-init.stdout Normal file
View File

@@ -0,0 +1,4 @@
chosen=.green
palette=.blue,.green,.red
pair.a=.blue pair.b=.green
PASS

4
examples/expected/0416-protocols-auto-type-erasure.ir
View File

@@ -1,6 +1,6 @@
@OS = internal global i64 0
@ARCH = internal global i64 0
@OS = internal global i64 6
@ARCH = internal global i64 4
@POINTER_SIZE = internal global i64 8
@__sx_default_context = internal global { { ptr, ptr, ptr }, ptr } { { ptr, ptr, ptr } { ptr null, ptr @__thunk_CAllocator_Allocator_alloc, ptr @__thunk_CAllocator_Allocator_dealloc }, ptr null }
@__Counter__SimpleCounter__vtable = internal constant { ptr, ptr } { ptr @__thunk_SimpleCounter_Counter_inc, ptr @__thunk_SimpleCounter_Counter_get }

1
examples/expected/1127-diagnostics-global-enum-literal-bad-variant.exit Normal file
View File

@@ -0,0 +1 @@
1

5
examples/expected/1127-diagnostics-global-enum-literal-bad-variant.stderr Normal file
View File

@@ -0,0 +1,5 @@
error: '.purple' is not a variant of enum 'Color'
--> examples/1127-diagnostics-global-enum-literal-bad-variant.sx:11:15
|
11 | bad : Color = .purple;
| ^^^^^^^

1
examples/expected/1127-diagnostics-global-enum-literal-bad-variant.stdout Normal file
View File

@@ -0,0 +1 @@

4
examples/expected/1309-ffi-objc-class-method-lowering.ir
View File

@@ -1,8 +1,8 @@
@__SxFoo_state_ivar = internal global ptr null
@__SxFoo_class = internal global ptr null
@OS = internal global i64 0
@ARCH = internal global i64 0
@OS = internal global i64 6
@ARCH = internal global i64 4
@POINTER_SIZE = internal global i64 8
@__sx_default_context = internal global { { ptr, ptr, ptr }, ptr } { { ptr, ptr, ptr } { ptr null, ptr @__thunk_CAllocator_Allocator_alloc, ptr @__thunk_CAllocator_Allocator_dealloc }, ptr null }
@__sx_objc_cstr_dealloc = internal global [8 x i8] c"dealloc\00"

4
examples/expected/1314-ffi-objc-class-dealloc-roundtrip.ir
View File

@@ -1,8 +1,8 @@
@__SxFoo_state_ivar = internal global ptr null
@__SxFoo_class = internal global ptr null
@OS = internal global i64 0
@ARCH = internal global i64 0
@OS = internal global i64 6
@ARCH = internal global i64 4
@POINTER_SIZE = internal global i64 8
@__sx_default_context = internal global { { ptr, ptr, ptr }, ptr } { { ptr, ptr, ptr } { ptr null, ptr @__thunk_CAllocator_Allocator_alloc, ptr @__thunk_CAllocator_Allocator_dealloc }, ptr null }
@__sx_objc_cstr_dealloc = internal global [8 x i8] c"dealloc\00"

4
examples/expected/1319-ffi-objc-property-sx-defined.ir
View File

@@ -1,8 +1,8 @@
@__SxBox_state_ivar = internal global ptr null
@__SxBox_class = internal global ptr null
@OS = internal global i64 0
@ARCH = internal global i64 0
@OS = internal global i64 6
@ARCH = internal global i64 4
@POINTER_SIZE = internal global i64 8
@__sx_default_context = internal global { { ptr, ptr, ptr }, ptr } { { ptr, ptr, ptr } { ptr null, ptr @__thunk_CAllocator_Allocator_alloc, ptr @__thunk_CAllocator_Allocator_dealloc }, ptr null }
@OBJC_CLASSLIST_REFERENCES_SxBox = internal global ptr null

4
examples/expected/1329-ffi-objc-call-03-selector-sharing.ir
View File

@@ -1,6 +1,6 @@
@OS = internal global i64 0
@ARCH = internal global i64 0
@OS = internal global i64 6
@ARCH = internal global i64 4
@POINTER_SIZE = internal global i64 8
@__sx_default_context = internal global { { ptr, ptr, ptr }, ptr } { { ptr, ptr, ptr } { ptr null, ptr @__thunk_CAllocator_Allocator_alloc, ptr @__thunk_CAllocator_Allocator_dealloc }, ptr null }
@OBJC_SELECTOR_REFERENCES_init = internal global ptr null

4
examples/expected/1332-ffi-objc-call-06-sret-return.ir
View File

@@ -1,6 +1,6 @@
@OS = internal global i64 0
@ARCH = internal global i64 0
@OS = internal global i64 6
@ARCH = internal global i64 4
@POINTER_SIZE = internal global i64 8
@__sx_default_context = internal global { { ptr, ptr, ptr }, ptr } { { ptr, ptr, ptr } { ptr null, ptr @__thunk_CAllocator_Allocator_alloc, ptr @__thunk_CAllocator_Allocator_dealloc }, ptr null }
@OBJC_SELECTOR_REFERENCES_tripleValue = internal global ptr null

4
examples/expected/1347-ffi-objc-dsl-07-mangling-table.ir
View File

@@ -1,6 +1,6 @@
@OS = internal global i64 0
@ARCH = internal global i64 0
@OS = internal global i64 6
@ARCH = internal global i64 4
@POINTER_SIZE = internal global i64 8
@__sx_default_context = internal global { { ptr, ptr, ptr }, ptr } { { ptr, ptr, ptr } { ptr null, ptr @__thunk_CAllocator_Allocator_alloc, ptr @__thunk_CAllocator_Allocator_dealloc }, ptr null }
@OBJC_SELECTOR_REFERENCES_length = internal global ptr null

4
examples/expected/1425-ffi-jni-main-03-ctor.ir
View File

@@ -1,6 +1,6 @@
@OS = internal global i64 0
@ARCH = internal global i64 0
@OS = internal global i64 6
@ARCH = internal global i64 4
@POINTER_SIZE = internal global i64 8
@g_held_view = internal global ptr null
@__sx_default_context = internal global { { ptr, ptr, ptr }, ptr } { { ptr, ptr, ptr } { ptr null, ptr @__thunk_CAllocator_Allocator_alloc, ptr @__thunk_CAllocator_Allocator_dealloc }, ptr null }