lower: diagnose passing a by-ref loop capture where a value is expected
`for xs: (*m)` binds `m` to a `*T`. Passing it directly to a parameter that wants `T` produced invalid IR that only LLVM's verifier caught, with the opaque 'Call parameter type does not match function signature'. Detect it at the call site and emit a clear error with a fix-it suggesting `m.*`. Add example 215 + expected output as a regression test.
This commit is contained in:
18
examples/215-ref-capture-value-arg-diagnostic.sx
Normal file
18
examples/215-ref-capture-value-arg-diagnostic.sx
Normal file
@@ -0,0 +1,18 @@
|
|||||||
|
// A by-reference loop capture (`for xs: (*m)`) binds `m` to a `*T`.
|
||||||
|
// Passing it where a `T` value is expected used to slip through to the
|
||||||
|
// LLVM verifier ("Call parameter type does not match function signature").
|
||||||
|
// The compiler now reports it at the call site with a fix-it: write `m.*`.
|
||||||
|
|
||||||
|
#import "modules/std.sx";
|
||||||
|
|
||||||
|
Move :: struct { flag: s64; }
|
||||||
|
|
||||||
|
take :: (m: Move) -> s64 { return m.flag; }
|
||||||
|
|
||||||
|
main :: () -> s32 {
|
||||||
|
moves : [2]Move = .[ Move.{ flag = 1 }, Move.{ flag = 2 } ];
|
||||||
|
for moves: (*m) {
|
||||||
|
take(m);
|
||||||
|
}
|
||||||
|
return 0;
|
||||||
|
}
|
||||||
@@ -6569,6 +6569,23 @@ pub const Lowering = struct {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
// A by-reference loop capture (`for xs: (*m)`) binds `m` to a `*T`.
|
||||||
|
// Passing it where a `T` value is expected used to slip through as a
|
||||||
|
// type-mismatched call that only LLVM's verifier rejected; report it
|
||||||
|
// here with a fix-it instead.
|
||||||
|
if (ai < param_types.len and arg.data == .identifier) {
|
||||||
|
if (self.refCapturePointee(arg)) |pointee| {
|
||||||
|
if (pointee == param_types[ai]) {
|
||||||
|
if (self.diagnostics) |d| {
|
||||||
|
const nm = arg.data.identifier.name;
|
||||||
|
const tn = self.formatTypeName(pointee);
|
||||||
|
const fix = std.fmt.allocPrint(self.alloc, "{s}.*", .{nm}) catch nm;
|
||||||
|
const pid = d.addFmtId(.err, arg.span, "by-reference loop capture '{s}' has type '*{s}', but '{s}' is expected here", .{ nm, tn, tn });
|
||||||
|
d.addHelpFmt(pid, arg.span, fix, "dereference it to pass the value: `{s}`", .{fix});
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
const val = self.lowerExpr(arg);
|
const val = self.lowerExpr(arg);
|
||||||
self.target_type = saved_target;
|
self.target_type = saved_target;
|
||||||
args.append(self.alloc, val) catch unreachable;
|
args.append(self.alloc, val) catch unreachable;
|
||||||
|
|||||||
1
tests/expected/215-ref-capture-value-arg-diagnostic.exit
Normal file
1
tests/expected/215-ref-capture-value-arg-diagnostic.exit
Normal file
@@ -0,0 +1 @@
|
|||||||
|
1
|
||||||
10
tests/expected/215-ref-capture-value-arg-diagnostic.txt
Normal file
10
tests/expected/215-ref-capture-value-arg-diagnostic.txt
Normal file
@@ -0,0 +1,10 @@
|
|||||||
|
error: by-reference loop capture 'm' has type '*Move', but 'Move' is expected here
|
||||||
|
--> /Users/agra/projects/sx/examples/215-ref-capture-value-arg-diagnostic.sx:15:14
|
||||||
|
|
|
||||||
|
15 | take(m);
|
||||||
|
| ^
|
||||||
|
|
||||||
|
help: dereference it to pass the value: `m.*`
|
||||||
|
|
|
||||||
|
15 | m.*
|
||||||
|
| ^
|
||||||
Reference in New Issue
Block a user