lab/sx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: diagnose ?? with a non-optional lhs instead of codegen panic (issue 0172)

Browse Source 
lowerNullCoalesce fed resolveOptionalInner's .unresolved (returned for a
non-optional lhs) into the merge-block params / optionalUnwrap / RHS
target type, reaching codegen and panicking 'unresolved type reached
LLVM emission'. Guard: when inferExprType(nc.lhs) is a resolved
non-optional type, emit a located diagnostic and bail; an .unresolved
lhs (prior error) is excluded to avoid double-report. ?? is optional-only
per specs.md (error unions use or/catch), so rejecting a failable lhs is
correct; comptime panic closed too.

Regression: examples/diagnostics/1200-diagnostics-null-coalesce-non-optional.sx.
Verified by 3 adversarial reviews, suite 790/0. Filed adjacent bug 0180
(?? lowering defects for generic/alias/tuple optional lhs).
This commit is contained in:
agra
2026-06-23 03:31:58 +03:00
parent e5b682e622
commit 58f97fff10
7 changed files with 113 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
examples/diagnostics/expected/1200-diagnostics-null-coalesce-non-optional.exit Normal file
View File

@@ -0,0 +1 @@
1

5
examples/diagnostics/expected/1200-diagnostics-null-coalesce-non-optional.stderr Normal file
View File

@@ -0,0 +1,5 @@
error: left operand of '??' must be an optional, but has type 'i64'
--> examples/diagnostics/1200-diagnostics-null-coalesce-non-optional.sx:15:8
|
15 | x := 5 ?? 7; // <- left operand of '??' must be an optional, but has type 'i64'
| ^

1
examples/diagnostics/expected/1200-diagnostics-null-coalesce-non-optional.stdout Normal file
View File

@@ -0,0 +1 @@