lab/sx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ffi M4.B helpers: objcPropertyKind + ARC runtime decls + xfail tests

Browse Source 
Three pieces, no behavior change yet:

1. `ObjcPropertyKind` enum (strong/weak/copy/assign) + `objcPropertyKind`
   helper in lower.zig. Reads `field.property_modifiers`, applies the
   default rule (`*<ObjC-class>` → strong; primitives → assign), and
   emits loud diagnostics for the silent-error budget:
   - unknown modifier name (typo) → "expected one of: strong, weak, copy, ..."
   - conflicting modifiers (e.g. `strong,weak`) → "mutually exclusive"
   - `weak` on non-object slot → "requires a pointer-to-Obj-C-class type"
   - `copy` on non-object slot → same
   - `strong` (default or explicit) on `*void` → "ambiguous: specify
     #property(strong|weak|copy|assign) explicitly"
   Called from `emitObjcDefinedClassPropertyImps` for validation; the
   returned kind isn't wired into setter/getter/dealloc yet — that's
   the next three commits.

2. `ensureArcRuntimeDecls` lazily declares libobjc's ARC helpers:
   objc_retain, objc_release, objc_storeWeak, objc_loadWeakRetained,
   objc_initWeak, objc_destroyWeak. Uses the existing
   `ensureCRuntimeDecl` pattern; idempotent.

3. Fix existing NSObject method names in std/objc.sx — `isEqual_`,
   `isKindOfClass_`, `respondsToSelector_` had trailing underscores
   that the selector mangling turned into double-colon selectors
   (`isEqual::`). Removed the trailing underscore so the selectors
   come out as `isEqual:`, `isKindOfClass:`, `respondsToSelector:`
   as Apple's runtime expects.

4. Two xfail regression tests:
   - ffi-objc-arc-02-strong-property: assigns child to parent's strong
     property, releases the original child reference. Midpoint check:
     child's dealloc should NOT have fired (strong setter retained).
     Pre-M4.B-setter: child dealloc fires immediately → "FAIL: child
     dealloc'd at midpoint" snapshot. Exit code 1.
   - ffi-objc-arc-03-weak-property: assigns target to holder's weak
     property, releases target. Reads holder.target → should be null
     (auto-niled). Pre-M4.B-getter/setter: reads stale pointer →
     "FAIL: weak property didn't auto-nil" snapshot.

These will turn green as M4.B setter (commit 2), getter (commit 3),
and dealloc-cleanup (commit 4) land. Each subsequent commit updates
the snapshot to reflect the now-passing output.

189/189 example tests pass; chess on iOS-sim green.
This commit is contained in:
agra
2026-05-26 22:58:30 +03:00
parent 8c3831acd2
commit 5c1d00a877
8 changed files with 292 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

141
src/ir/lower.zig
View File

@@ -12036,6 +12036,141 @@ pub const Lowering = struct {
/// Both IMPs land in the cache's methods slice with appropriate
/// selectors + encodings; emit_llvm's class_addMethod loop wires
/// them up like any other instance method.
/// M4.B — interpretation of `#property(...)` modifiers for ARC.
/// `assign` is the default for primitives (direct store, no ARC ops);
/// `strong` is the default for pointer-to-object types (retain on
/// assign, release on dealloc); `weak` and `copy` are explicit. The
/// helper rejects ambiguous combinations loudly per the silent-error
/// budget — `*void` requires explicit modifier, `weak` requires an
/// object-pointer slot.
const ObjcPropertyKind = enum {
assign, // primitives or explicitly opted-out object slots
strong, // default for *<ObjC-class> — retain on assign, release on dealloc
weak, // objc_storeWeak / objc_loadWeakRetained — auto-nilling
copy, // [val copy] on assign — for immutable-wanting String/Array slots
pub fn isObject(k: ObjcPropertyKind) bool {
return k == .strong or k == .weak or k == .copy;
}
};
/// Resolve a `#property(...)` field's ARC kind. Loud at compile time
/// for known footguns (per the silent-error budget in the plan):
/// - unknown modifier name (typo) → diagnostic
/// - `weak` on a non-object field type → diagnostic
/// - `strong` (explicit or defaulted) on `*void` (ambiguous: Obj-C
/// object vs raw memory) → require explicit modifier
fn objcPropertyKind(self: *Lowering, field: ast.ForeignFieldDecl) ObjcPropertyKind {
// Survey the modifier list.
var has_strong = false;
var has_weak = false;
var has_copy = false;
var has_assign = false;
for (field.property_modifiers) |mod| {
if (std.mem.eql(u8, mod, "strong")) has_strong = true
else if (std.mem.eql(u8, mod, "weak")) has_weak = true
else if (std.mem.eql(u8, mod, "copy")) has_copy = true
else if (std.mem.eql(u8, mod, "assign")) has_assign = true
else if (std.mem.eql(u8, mod, "readonly")) {
// Orthogonal to ARC kind — no-op here.
}
else if (std.mem.eql(u8, mod, "nonatomic") or std.mem.eql(u8, mod, "atomic")) {
// Atomicity — recorded for the property attribute string;
// doesn't affect the ARC kind.
}
else if (std.mem.startsWith(u8, mod, "getter(") or std.mem.startsWith(u8, mod, "setter(")) {
// Selector overrides — handled elsewhere.
}
else {
if (self.diagnostics) |d| {
const span = ast.Span{ .start = 0, .end = 0 };
d.addFmt(.err, span, "unknown #property modifier '{s}' on field '{s}' — expected one of: strong, weak, copy, assign, readonly, nonatomic, atomic, getter(\"...\"), setter(\"...\")", .{ mod, field.name });
}
}
}
// Mutually-exclusive ARC modifiers — at most one.
const explicit_count: u32 =
(@as(u32, if (has_strong) 1 else 0)) +
(@as(u32, if (has_weak) 1 else 0)) +
(@as(u32, if (has_copy) 1 else 0)) +
(@as(u32, if (has_assign) 1 else 0));
if (explicit_count > 1) {
if (self.diagnostics) |d| {
const span = ast.Span{ .start = 0, .end = 0 };
d.addFmt(.err, span, "conflicting #property modifiers on field '{s}' — strong/weak/copy/assign are mutually exclusive", .{field.name});
}
}
// Resolve the field's type to decide defaults + validate.
const field_ty = self.resolveType(field.field_type);
const is_pointer = !field_ty.isBuiltin() and self.module.types.get(field_ty) == .pointer;
const is_object_ptr = is_pointer and blk: {
const pointee = self.module.types.get(field_ty).pointer.pointee;
// `*void` is NOT considered an object pointer — ambiguous.
if (pointee == .void) break :blk false;
// `*T` where T is a foreign-class struct (Obj-C class).
if (pointee.isBuiltin()) break :blk false;
const pointee_info = self.module.types.get(pointee);
if (pointee_info != .@"struct") break :blk false;
const struct_name = self.module.types.getString(pointee_info.@"struct".name);
const fcd = self.foreign_class_map.get(struct_name) orelse break :blk false;
break :blk fcd.runtime == .objc_class or fcd.runtime == .objc_protocol;
};
// `weak` requires an object pointer — `weak s32` is meaningless and
// would invoke objc_storeWeak on a non-object slot.
if (has_weak and !is_object_ptr) {
if (self.diagnostics) |d| {
const span = ast.Span{ .start = 0, .end = 0 };
d.addFmt(.err, span, "#property(weak) on field '{s}' requires a pointer-to-Obj-C-class type; got '{s}'", .{ field.name, self.module.types.typeName(field_ty) });
}
}
// `copy` requires an object pointer — `copy s32` makes no sense.
if (has_copy and !is_object_ptr) {
if (self.diagnostics) |d| {
const span = ast.Span{ .start = 0, .end = 0 };
d.addFmt(.err, span, "#property(copy) on field '{s}' requires a pointer-to-Obj-C-class type (typically NSString or NSArray)", .{field.name});
}
}
// `*void` is ambiguous (Obj-C object vs raw memory): require explicit
// modifier so the user opts into ARC semantics consciously.
if (is_pointer) {
const pointee = self.module.types.get(field_ty).pointer.pointee;
if (pointee == .void and explicit_count == 0) {
if (self.diagnostics) |d| {
const span = ast.Span{ .start = 0, .end = 0 };
d.addFmt(.err, span, "#property on field '{s}' of type '*void' is ambiguous — specify `#property(strong|weak|copy|assign)` explicitly (Obj-C object vs raw memory)", .{field.name});
}
return .assign; // assume safe default to keep compilation going
}
}
// Apply explicit modifier or default.
if (has_weak) return .weak;
if (has_copy) return .copy;
if (has_strong) return .strong;
if (has_assign) return .assign;
// Default: object pointers → strong; everything else → assign.
return if (is_object_ptr) .strong else .assign;
}
/// Lazily declare libobjc's ARC runtime helpers. Idempotent — uses
/// `ensureCRuntimeDecl` which skips already-declared symbols. Called
/// from the property setter/getter and -dealloc emission paths when
/// they need to emit a retain/release/storeWeak/etc.
fn ensureArcRuntimeDecls(self: *Lowering) void {
const ptr_void = self.module.types.ptrTo(.void);
_ = self.ensureCRuntimeDecl("objc_retain", &.{ptr_void}, ptr_void);
_ = self.ensureCRuntimeDecl("objc_release", &.{ptr_void}, .void);
_ = self.ensureCRuntimeDecl("objc_storeWeak", &.{ ptr_void, ptr_void }, ptr_void);
_ = self.ensureCRuntimeDecl("objc_loadWeakRetained", &.{ptr_void}, ptr_void);
_ = self.ensureCRuntimeDecl("objc_initWeak", &.{ ptr_void, ptr_void }, ptr_void);
_ = self.ensureCRuntimeDecl("objc_destroyWeak", &.{ptr_void}, .void);
}
fn emitObjcDefinedClassPropertyImps(self: *Lowering, fcd: *const ast.ForeignClassDecl, field: ast.ForeignFieldDecl) void {
const state_ty = self.objcDefinedStateStructType(fcd);
const state_info = self.module.types.get(state_ty);
@@ -12052,6 +12187,12 @@ pub const Lowering = struct {
const fidx = field_idx orelse return;
const field_ty = self.resolveType(field.field_type);
// M4.B: validate modifiers + resolve ARC kind. Side-effect: emits
// diagnostics for typos, weak-on-non-object, ambiguous *void, etc.
// For now the setter/getter still emit bare load/store; subsequent
// M4.B commits wire the actual ARC ops keyed on this kind.
_ = self.objcPropertyKind(field);
// (1) Getter: __<Cls>_<field>_imp
self.emitObjcDefinedPropertyGetter(fcd, field, state_ty, fidx, field_ty);