fix(ir): const evaluators' field-access arm is raw value-shadow aware [F0.11]
A backtick raw value-shadow receiver (`` `f64 := … `` then `` `f64.epsilon ``, `` `s8.max ``) was misclassified as the builtin numeric-limit accessor by the shared compile-time evaluators. The sibling `isFloatValuedExpr` already guards this with an `is_raw` check, but `evalConstFloatExpr` / `evalConstIntExpr` did not — so once a raw value-shadow's field read flowed into the unified float→int narrowing rule or an array-dim count, the float folder returned the BUILTIN `f64.epsilon` (2.22e-16) and wrongly errored, and the integer folder turned `` `s8.max `` into the builtin `127` (a fabricated 127-element array). Both evaluators' field-access arms now mirror `isFloatValuedExpr`'s `is_raw` guard: a raw receiver yields `obj_name = null`, so it is never a numeric-limit/pack leaf and falls through to the ordinary runtime field read. A raw value-shadow is a mutable-local field (an observable later reassignment), so it is genuinely runtime and must not be const-folded — it now behaves exactly like a plainly-named field read: `` `f64.epsilon `` narrowing into `s64` truncates its field value (11.5 → 11, identical to `b.epsilon`), and `` `s8.max `` as an array dimension is rejected as a non-constant count (identical to `b.max`). The bare builtin path is unchanged. Regression (issue 0095 / F0.11-7): - examples/0169-types-value-shadow-field-narrowing.sx (positive — raw float-field read narrows/truncates, mutation proves runtime, bare limit still folds) - examples/1148-diagnostics-value-shadow-field-dim-not-const.sx (negative — raw int-field dim rejected as non-const) - program_index.test.zig "a backtick raw-shadow receiver is a field read, not a numeric-limit fold (F0.11-7)" specs.md + readme.md note the value-shadow rule extends into the narrowing/count contexts.
This commit is contained in:
@@ -141,6 +141,12 @@ fn nFloat(v: f64) ast.Node {
|
||||
fn nIdent(name: []const u8) ast.Node {
|
||||
return .{ .span = .{ .start = 0, .end = 0 }, .data = .{ .identifier = .{ .name = name } } };
|
||||
}
|
||||
/// A backtick RAW identifier (`` `f64 ``): same spelling as a builtin type, but
|
||||
/// bound as a value — so a field access on it is an ordinary field read, never a
|
||||
/// numeric-limit fold (F0.11-7).
|
||||
fn nIdentRaw(name: []const u8) ast.Node {
|
||||
return .{ .span = .{ .start = 0, .end = 0 }, .data = .{ .identifier = .{ .name = name, .is_raw = true } } };
|
||||
}
|
||||
fn nBin(op: ast.BinaryOp.Op, l: *ast.Node, r: *ast.Node) ast.Node {
|
||||
return .{ .span = .{ .start = 0, .end = 0 }, .data = .{ .binary_op = .{ .op = op, .lhs = l, .rhs = r } } };
|
||||
}
|
||||
@@ -469,6 +475,40 @@ test "evalConstFloatExpr folds comptime float expressions, halts on runtime leav
|
||||
try std.testing.expect(eval(&divz, ctx) == null);
|
||||
}
|
||||
|
||||
test "a backtick raw-shadow receiver is a field read, not a numeric-limit fold (F0.11-7)" {
|
||||
const evalf = pi.evalConstFloatExpr;
|
||||
const evali = pi.evalConstIntExpr;
|
||||
const ctx = DimCtx{};
|
||||
|
||||
// BARE type receiver (`is_raw = false`) → the numeric-limit accessor folds:
|
||||
// `f64.epsilon` is the builtin eps, `s8.max` is 127.
|
||||
var f64ty = nIdent("f64");
|
||||
var s8ty = nIdent("s8");
|
||||
var bare_feps = nField(&f64ty, "epsilon");
|
||||
var bare_smax = nField(&s8ty, "max");
|
||||
try std.testing.expectEqual(@as(?f64, @as(f64, std.math.floatEps(f64))), evalf(&bare_feps, ctx));
|
||||
try std.testing.expectEqual(@as(?i64, std.math.maxInt(i8)), evali(&bare_smax, ctx));
|
||||
|
||||
// RAW receiver (`` `f64 ``/`` `s8 ``) shadows the builtin with a VALUE — the
|
||||
// field access is an ordinary runtime field READ, so it is NOT a compile-time
|
||||
// leaf in either evaluator (→ null), exactly as the sibling `isFloatValuedExpr`
|
||||
// already treats it. The whole point: a value-shadow can never be misread as
|
||||
// the builtin limit (issue 0095 / F0.11-7).
|
||||
var f64raw = nIdentRaw("f64");
|
||||
var s8raw = nIdentRaw("s8");
|
||||
var raw_feps = nField(&f64raw, "epsilon");
|
||||
var raw_smax = nField(&s8raw, "max");
|
||||
try std.testing.expect(evalf(&raw_feps, ctx) == null);
|
||||
try std.testing.expect(evali(&raw_smax, ctx) == null);
|
||||
// The float evaluator must also refuse it (it delegates the int path first):
|
||||
try std.testing.expect(evalf(&raw_smax, ctx) == null);
|
||||
|
||||
// `isFloatValuedExpr` (the consistency anchor) agrees: bare float-limit is
|
||||
// float-valued, raw shadow is not.
|
||||
try std.testing.expect(pi.isFloatValuedExpr(&bare_feps, ctx));
|
||||
try std.testing.expect(!pi.isFloatValuedExpr(&raw_feps, ctx));
|
||||
}
|
||||
|
||||
test "foldCountI64 / foldDimU32 fold an integral float count, reject a non-integral one" {
|
||||
const ctx = DimCtx{}; // M = 4, F = 2.5 (non-integral float const)
|
||||
|
||||
|
||||
Reference in New Issue
Block a user