fixes
This commit is contained in:
55
examples/issue-0007.sx
Normal file
55
examples/issue-0007.sx
Normal file
@@ -0,0 +1,55 @@
|
||||
// issue-0007: protocol value stores dangling pointer to stack local
|
||||
//
|
||||
// When a concrete value is converted to a protocol value inside a function,
|
||||
// and the protocol value is stored in a List (via a wrapper struct), the
|
||||
// protocol value's data pointer points to the stack-local variable rather
|
||||
// than a heap-allocated copy. After the function returns, the pointer is
|
||||
// dangling and method dispatch crashes (SIGSEGV/SIGBUS).
|
||||
//
|
||||
// Inside the function: dispatch works (stack local still alive)
|
||||
// After the function returns: dispatch crashes (stack local gone)
|
||||
|
||||
#import "modules/std.sx";
|
||||
|
||||
Sizable :: protocol {
|
||||
size :: () -> s64;
|
||||
}
|
||||
|
||||
Widget :: struct { value: s64; }
|
||||
impl Sizable for Widget {
|
||||
size :: (self: *Widget) -> s64 { self.value; }
|
||||
}
|
||||
|
||||
// Wrapper struct with a protocol field (like ViewChild)
|
||||
Item :: struct {
|
||||
view: Sizable;
|
||||
}
|
||||
|
||||
Container :: struct {
|
||||
items: List(Item);
|
||||
|
||||
add :: (self: *Container, w: Widget) {
|
||||
p := w; // local copy
|
||||
self.items.append(Item.{ view = p }); // protocol created from stack local `p`
|
||||
|
||||
// Works here: stack local `p` is still alive
|
||||
out("inside add: ");
|
||||
print("{}\n", self.items.items[self.items.len - 1].view.size());
|
||||
}
|
||||
}
|
||||
|
||||
main :: () -> void {
|
||||
c : Container = .{};
|
||||
c.add(Widget.{ value = 42 });
|
||||
c.add(Widget.{ value = 99 });
|
||||
|
||||
// BUG: items[0] should return 42, but returns 99 (reads items[1]'s stack slot)
|
||||
// Both protocol values point to the same stack address (the `p` local in add())
|
||||
r0 := c.items.items[0].view.size();
|
||||
r1 := c.items.items[1].view.size();
|
||||
print("items[0] = {} (expected 42)\n", r0);
|
||||
print("items[1] = {} (expected 99)\n", r1);
|
||||
|
||||
// With more stack activity between add() and the reads, this crashes
|
||||
// (stack memory overwritten by other function calls)
|
||||
}
|
||||
Reference in New Issue
Block a user