1bc60d3a35
lowerEnumLiteral resolved the variant against the raw destination type,
so any non-enum destination fell into resolveVariantValue's silent
return-0 tail with the enum_init stamped as the wrong type:
- ?E destinations produced variant 0 mis-typed as the optional
(observed as variant 0 OR null, layout-dependent);
- builtin destinations (i64) silently became 0;
- unknown variants of real enums silently became variant 0;
- a destination-less literal panicked LLVM emission (unresolved
type reached codegen).
Now: optional destinations unwrap to the child enum (the coercion
layer's .optional_wrap handles E -> ?E), and the remaining shapes are
diagnosed — unknown variant (with the variant list, via the new
emitBadEnumVariant twin of emitBadVariant), non-enum destination, and
no destination (cascade-guarded: silent when the destination's type
already failed to resolve and was reported).
Regression tests: examples/0183 (return/assign/reassign into ?Enum,
non-zero variants, null path) + examples/1169/1170 (each diagnostic);
all three FAIL on pre-fix master. zig build test 426/426;
tests/run_examples.sh 598/598.
35 lines
1.2 KiB
Plaintext
35 lines
1.2 KiB
Plaintext
// Enum literals flowing into OPTIONAL destinations resolve against the
|
|
// optional's CHILD type and wrap (issue 0098). Pre-fix, the literal fell
|
|
// into resolveVariantValue's non-enum fallback: variant 0, mis-typed as
|
|
// the optional itself — `return .android_apk;` was observed by callers as
|
|
// `.ios` or even null, layout-dependent.
|
|
#import "modules/std.sx";
|
|
|
|
Platform :: enum u8 { ios; android_apk; macos; linux; windows; }
|
|
|
|
classify :: (n: i64) -> ?Platform {
|
|
if n == 1 { return .android_apk; } // return: literal into ?Platform
|
|
if n == 2 { return .windows; } // non-zero, non-adjacent variant
|
|
return null;
|
|
}
|
|
|
|
main :: () -> i32 {
|
|
p := classify(1);
|
|
if p == null { print("BUG: null\n"); return 1; }
|
|
if p! != .android_apk { print("BUG: wrong variant\n"); return 2; }
|
|
|
|
w := classify(2);
|
|
if w == null or w! != .windows { print("BUG: windows\n"); return 3; }
|
|
|
|
if classify(9) != null { print("BUG: not null\n"); return 4; }
|
|
|
|
// assignment + reassignment: literal into a ?Platform slot
|
|
q : ?Platform = .macos;
|
|
if q == null or q! != .macos { print("BUG: assign\n"); return 5; }
|
|
q = .linux;
|
|
if q! != .linux { print("BUG: reassign\n"); return 6; }
|
|
|
|
print("ok\n");
|
|
return 0;
|
|
}
|