b053c64149
size_of, align_of, field_count, type_name, type_eq, type_is_unsigned,
and is_flags silently reinterpreted a value argument as a type:
type_is_unsigned(6) read 6 as a TypeId index (types[6] = u8 -> true),
size_of(6)/size_of(true) sized its typeof (8), type_name(6) returned
types[6]'s name. Per Agra's ruling, all 7 now strictly require a type
(compile-time): a value argument is a compile error.
One shared guard (Lowering.reflectionTypeArgGuard, run at the top of
tryLowerReflectionCall) classifies each arg via reflectionArgIsType: a
spelled / compile-time type or generic type parameter (isStaticTypeArg),
or a runtime Type value (static type .any -- type_of(x), a []Type
element list[i], a Type-typed local/field/param) is accepted; anything
else is rejected with "<builtin> expects a type, got '<type>'". The
runtime path for type_name / type_is_unsigned is preserved (the {}
formatter calls type_is_unsigned(type_of(val)) at runtime). The 5
comptime-only builtins stay comptime-only (runtime reflection deferred).
Regression: examples/1144-diagnostics-reflection-builtin-needs-type.sx
(reject cases across all 7, exit 1). Unit test: reflectionArgIsType in
lower.test.zig. specs.md / readme.md document the strict type
requirement (and add the previously-undocumented align_of, type_eq,
type_is_unsigned). issues/0090 RESOLVED banner updated.
29 lines
1.4 KiB
Plaintext
29 lines
1.4 KiB
Plaintext
// The 7 type-introspection builtins (size_of, align_of, field_count,
|
|
// type_name, type_eq, type_is_unsigned, is_flags) take ONLY types. A
|
|
// value argument is a compile-time error, not a silently-reinterpreted
|
|
// TypeId index.
|
|
//
|
|
// Regression (issue 0090, attempt 2): each builtin used to accept a
|
|
// non-type value and reinterpret it — `type_is_unsigned(6)` read 6 as a
|
|
// TypeId and returned the signedness of types[6] (`u8` → true);
|
|
// `size_of(true)` sized `typeof(true)` (8). The strict `$T: Type` guard
|
|
// (`Lowering.reflectionTypeArgGuard`) now rejects any argument whose
|
|
// static type is not `Type` and emits "<builtin> expects a type, got
|
|
// '<type>'" at the offending argument, aborting (exit 1).
|
|
//
|
|
// Reject cases use `true`/`1.5` (whose types — bool/f64 — are stable)
|
|
// rather than an integer literal, so the pinned diagnostics don't drift
|
|
// when the int-literal default type changes.
|
|
|
|
#import "modules/std.sx";
|
|
|
|
main :: () {
|
|
print("{}\n", size_of(true)); // bool, not a type
|
|
print("{}\n", align_of(1.5)); // f64, not a type
|
|
print("{}\n", field_count(true)); // bool, not a type
|
|
print("{}\n", type_name(1.5)); // f64, not a type
|
|
print("{}\n", type_eq(true, false)); // both bool — both rejected
|
|
print("{}\n", type_is_unsigned(true)); // bool, not a type
|
|
print("{}\n", is_flags(1.5)); // f64, not a type
|
|
}
|