fcc76b9391
The reserved/builtin-type-name binding diagnostic was a hand-walked subset
of binding-bearing AST nodes with a silent `else => {}`, so each review
found another syntactic binding form that bypassed it and hit the original
LLVM verifier abort: destructure names (`s2, x := …`), `impl` method
params/locals, and `if` / `while` / `for` / match-arm / `catch` / `onfail`
captures.
Rewrite `checkBindingNames` (src/ir/semantic_diagnostics.zig) as an
EXHAUSTIVE `switch` over every `Node.Data` tag with NO `else` arm — a future
binding-bearing node type now fails to compile until it is handled here, so
coverage is enforced by the compiler instead of a hand-maintained list. The
check stays in the pre-lowering semantic pass rather than moving to the
`Scope.put` scope-registration choke point: lowering is lazy, so an
uncalled function's bindings never reach `Scope.put`, yet they must still be
rejected at their declaration (e.g. the never-called `takes_u8` in 1119).
No lowering special-case; `lower.zig` unchanged.
Regression tests (fail-before: LLVM abort or silent accept → pass-after:
clean diagnostic, exit 1):
- 1121 control-flow: destructure, if/while bindings, for capture+index,
match-arm capture
- 1122 impl-block method: reserved param AND reserved local
- 1123 catch + onfail tag bindings
- 1124 destructure name reserved in an imported module
Existing 0125 / 1119 / 0135 / 1120 tests kept; full suite 368 passed.
16 lines
722 B
Plaintext
16 lines
722 B
Plaintext
// A reserved type name used as a DESTRUCTURE binding name (`s2`) is rejected
|
|
// even when it lives in an IMPORTED module — the exhaustive binding-name walk
|
|
// descends the `namespace_decl` an `mod :: #import` wraps and renders the
|
|
// diagnostic against that module's source (issue 0077's universal-coverage
|
|
// rule applied to the destructure form). Without it the binding reaches
|
|
// lowering and aborts LLVM verification.
|
|
//
|
|
// Regression (issues 0076 + 0077, attempt-4 coverage). Expected: one clean
|
|
// diagnostic pointing at the imported module's `s2, rest := ...`, exit 1.
|
|
#import "modules/std.sx";
|
|
mod :: #import "1124-diagnostics-imported-reserved-destructure/mod.sx";
|
|
|
|
main :: () -> s32 {
|
|
return mod.run();
|
|
}
|