f49a49cd07
A value binding (local/global `var` or a parameter) spelled as a reserved/builtin type name parses as a `.type_expr` rather than an `.identifier` (parser.zig, via `Type.fromName`), so the address-of family in lower.zig never saw a scoped local and mis-lowered it — loading the aggregate and passing it by value to a `ptr` parameter (LLVM verifier abort, or a silent `*self`-mutation-losing copy). Add a declaration-site diagnostic in semantic_diagnostics.zig (`UnknownTypeChecker.checkBindingName`): reject any parameter name or `var` binding name (`:=` / typed-local / global forms) whose spelling collides with a reserved type name. `isReservedTypeName` defers to the parser's own classifier (`types.Type.fromName`) so the rejected set never drifts from the set that would parse as a type — the named builtins (bool/string/void/f32/f64/usize/isize/Any) and `[su]N` over sx's 1-64 range. Bare value names (`s`, `self`, `index`) are untouched. No lowering special-case; the `.identifier`-only address-of paths are correct once type-shaped names can never be bound. The rejected attempt-1 `bareVarName` approach was never landed. Tests: - 0125-types-type-named-var-rejected: `:=` form (s2) rejected (repurposed from the old test that asserted the now-illegal behavior). - 1119-diagnostics-reserved-type-name-as-identifier: parameter (u8), typed-local (s64, bool), `:=` (string) forms rejected. - 0135-types-self-streaming-nonreserved: positive — `*self` streaming with non-reserved names accumulates correctly via both call styles. - 0904-optionals: renamed incidental locals s1/s2 -> filled/empty.
17 lines
608 B
Plaintext
17 lines
608 B
Plaintext
// A value binding (parameter or local `var`) spelled as a reserved/builtin
|
|
// type name is rejected at the declaration site, across every declaration
|
|
// form: a parameter name (`u8`), a typed local (`s64`, `bool`), and a `:=`
|
|
// local (`string`). Such a spelling parses as a `.type_expr` rather than an
|
|
// `.identifier`, so the address-of family in lowering mis-lowers it (issue
|
|
// 0076). Expected: one error per offending name; exit 1.
|
|
#import "modules/std.sx";
|
|
|
|
takes_u8 :: (u8: s32) -> s32 { return u8; }
|
|
|
|
main :: () -> s32 {
|
|
s64 : s32 = 3;
|
|
bool : bool = true;
|
|
string := "x";
|
|
return 0;
|
|
}
|