f49a49cd07
A value binding (local/global `var` or a parameter) spelled as a reserved/builtin type name parses as a `.type_expr` rather than an `.identifier` (parser.zig, via `Type.fromName`), so the address-of family in lower.zig never saw a scoped local and mis-lowered it — loading the aggregate and passing it by value to a `ptr` parameter (LLVM verifier abort, or a silent `*self`-mutation-losing copy). Add a declaration-site diagnostic in semantic_diagnostics.zig (`UnknownTypeChecker.checkBindingName`): reject any parameter name or `var` binding name (`:=` / typed-local / global forms) whose spelling collides with a reserved type name. `isReservedTypeName` defers to the parser's own classifier (`types.Type.fromName`) so the rejected set never drifts from the set that would parse as a type — the named builtins (bool/string/void/f32/f64/usize/isize/Any) and `[su]N` over sx's 1-64 range. Bare value names (`s`, `self`, `index`) are untouched. No lowering special-case; the `.identifier`-only address-of paths are correct once type-shaped names can never be bound. The rejected attempt-1 `bareVarName` approach was never landed. Tests: - 0125-types-type-named-var-rejected: `:=` form (s2) rejected (repurposed from the old test that asserted the now-illegal behavior). - 1119-diagnostics-reserved-type-name-as-identifier: parameter (u8), typed-local (s64, bool), `:=` (string) forms rejected. - 0135-types-self-streaming-nonreserved: positive — `*self` streaming with non-reserved names accumulates correctly via both call styles. - 0904-optionals: renamed incidental locals s1/s2 -> filled/empty.
31 lines
1.1 KiB
Plaintext
31 lines
1.1 KiB
Plaintext
// A `*self`-mutating streaming pattern with NON-reserved binding names
|
|
// (`hasher`, `ctx`) compiles and accumulates state correctly through BOTH
|
|
// call styles — explicit address-of `update(@h, ...)` and autoref
|
|
// `h.update(...)` — across multiple mutating calls. Proves the
|
|
// `.identifier`-only address-of paths in lowering are correct as-is, with no
|
|
// type-shaped-name special-case (companion to the issue-0076 rejection of
|
|
// type-named identifiers).
|
|
#import "modules/std.sx";
|
|
|
|
Hasher :: struct { total: s64 = 0; count: s64 = 0; }
|
|
|
|
update :: (self: *Hasher, n: s64) {
|
|
self.total += n;
|
|
self.count += 1;
|
|
}
|
|
|
|
main :: () -> s32 {
|
|
hasher := Hasher.{ total = 0, count = 0 };
|
|
update(@hasher, 10); // explicit address-of receiver
|
|
hasher.update(20); // autoref receiver
|
|
update(@hasher, 30);
|
|
hasher.update(40);
|
|
print("hasher total={} count={}\n", hasher.total, hasher.count);
|
|
|
|
ctx := Hasher.{ total = 100, count = 0 };
|
|
ctx.update(5);
|
|
update(@ctx, 7);
|
|
print("ctx total={} count={}\n", ctx.total, ctx.count);
|
|
return 0;
|
|
}
|