Files
sx/src/ir/conversions.test.zig
agra 097d23d909 fix: presence-preserving optional->optional coercion (issue 0180)
The generic-?? wrong-fallback was not in lowerNullCoalesce: coercing
?A -> ?B (differing payload, e.g. the ?i32->?i64 call-arg coercion when
instantiating unwrap_or(99, ?i32)) routed through .optional_wrap, which
unconditionally unwrapped the source and re-wrapped as ALWAYS-PRESENT, so
a null became present-zero everywhere (args, returns, field init,
var-decl, ??). Add a CoercionPlan.optional_to_optional (conversions.zig)
+ a presence-preserving arm in coerceMode (coerce.zig): has_value ->
present: unwrap+coerce-child+wrap-present; absent: constNull(dst); merge
via a dst_ty block param. lowerVarDecl gains a !src_is_optional guard so
an annotated x : ?B = <?A> routes through the same arm (also makes
aggregate-payload var-decl ?[3]i64->?[]i64 / ?Concrete->?Protocol work).

Alias-optional struct-literal default already works (grouping + 0166);
a 1-tuple default ?(i32,) ?? 5 now emits a clean diagnostic instead of an
LLVM PHI abort (no implicit scalar->1-tuple coercion per spec).

Regressions: optionals/0916 (generic ??), 0917 (alias struct default),
0918 (var-decl optional->optional), diagnostics/1202 (1-tuple default) +
a conversions.test.zig unit test. Verified by 3 adversarial reviews,
suite 798/0.
2026-06-23 16:16:47 +03:00

131 lines
6.5 KiB
Zig

// Tests for conversions.zig — the coercion-planning classifier
// (`CoercionResolver`). Reached via `ir.CoercionResolver{ .l = &lowering }`,
// mirroring the other facade tests. These pin the `classify` / `classifyXX`
// DECISIONS; `coerceToType` / `lowerXX` emit them (emission stays in Lowering).
const std = @import("std");
const ast = @import("../ast.zig");
const Node = ast.Node;
const ir_mod = @import("ir.zig");
const TypeId = ir_mod.TypeId;
const Lowering = ir_mod.Lowering;
const CoercionResolver = ir_mod.CoercionResolver;
const Plan = CoercionResolver.CoercionPlan;
const XXPlan = CoercionResolver.XXPlan;
fn protoMethodReq(name: []const u8) ast.ProtocolMethodDecl {
return .{ .name = name, .params = &.{}, .param_names = &.{}, .return_type = null, .default_body = null };
}
test "conversions: classify covers the built-in coercion ladder" {
var arena = std.heap.ArenaAllocator.init(std.testing.allocator);
defer arena.deinit();
const alloc = arena.allocator();
var module = ir_mod.Module.init(alloc);
defer module.deinit();
var l = Lowering.init(&module);
const cr = CoercionResolver{ .l = &l };
const tt = &module.types;
// no-op + Any box/unbox.
try std.testing.expectEqual(Plan.no_op, cr.classify(.i64, .i64));
try std.testing.expectEqual(Plan.unbox_any, cr.classify(.any, .i64));
try std.testing.expectEqual(Plan.box_any, cr.classify(.i64, .any));
// Numeric / pointer ladder.
try std.testing.expectEqual(Plan.widen, cr.classify(.i32, .i64));
try std.testing.expectEqual(Plan.narrow, cr.classify(.i64, .i32));
try std.testing.expectEqual(Plan.int_to_float, cr.classify(.i32, .f64));
try std.testing.expectEqual(Plan.float_to_int, cr.classify(.f64, .i32));
const ptr_i64 = tt.ptrTo(.i64);
try std.testing.expectEqual(Plan.ptr_int_bitcast, cr.classify(ptr_i64, .i64));
try std.testing.expectEqual(Plan.ptr_int_bitcast, cr.classify(.i64, ptr_i64));
// Optional wrap / unwrap, and void → optional.
const opt_i64 = tt.optionalOf(.i64);
try std.testing.expectEqual(Plan.optional_wrap, cr.classify(.i64, opt_i64));
try std.testing.expectEqual(Plan.optional_unwrap, cr.classify(opt_i64, .i64));
try std.testing.expectEqual(Plan.void_to_optional, cr.classify(.void, opt_i64));
// `?A → ?B` (differing payloads) is a presence-preserving payload coercion,
// NOT the always-present unwrap-then-rewrap that the `.optional_wrap` arm
// produced (issue 0180). Same-payload optionals are `.no_op`.
const opt_i32 = tt.optionalOf(.i32);
try std.testing.expectEqual(Plan.optional_to_optional, cr.classify(opt_i32, opt_i64));
try std.testing.expectEqual(Plan.no_op, cr.classify(opt_i64, opt_i64));
// `?T → bool` is NOT an unwrap-then-narrow presence test (issue 0169):
// it must reject, never silently produce `false`. But `?bool → bool`
// is a genuine unwrap of a bool payload.
try std.testing.expectEqual(Plan.optional_to_bool_reject, cr.classify(opt_i64, .bool));
const opt_bool = tt.optionalOf(.bool);
try std.testing.expectEqual(Plan.optional_unwrap, cr.classify(opt_bool, .bool));
// Tuple → tuple, same arity.
const t_ss = tt.intern(.{ .tuple = .{ .fields = &[_]TypeId{ .i64, .i64 }, .names = null } });
const t_ii = tt.intern(.{ .tuple = .{ .fields = &[_]TypeId{ .i32, .i32 }, .names = null } });
try std.testing.expectEqual(Plan.tuple_elementwise, cr.classify(t_ss, t_ii));
// Closure value → bare fn-ptr: rejected.
const clo = tt.closureType(&.{}, .void);
const fnp = tt.functionType(&.{}, .void);
try std.testing.expectEqual(Plan.closure_to_fn_reject, cr.classify(clo, fnp));
// Two unrelated structs: no built-in applies → `.none` (lowerXX then tries
// a user `Into`). No silent numeric default.
const a = tt.intern(.{ .@"struct" = .{ .name = tt.internString("A"), .fields = &.{} } });
const b = tt.intern(.{ .@"struct" = .{ .name = tt.internString("B"), .fields = &.{} } });
try std.testing.expectEqual(Plan.none, cr.classify(a, b));
}
test "conversions: classify selects protocol erasure for a concrete source" {
var arena = std.heap.ArenaAllocator.init(std.testing.allocator);
defer arena.deinit();
const alloc = arena.allocator();
var module = ir_mod.Module.init(alloc);
defer module.deinit();
var l = Lowering.init(&module);
const cr = CoercionResolver{ .l = &l };
const methods = [_]ast.ProtocolMethodDecl{protoMethodReq("draw")};
const pd = ast.ProtocolDecl{ .name = "Drawable", .methods = &methods };
l.registerProtocolDecl(&pd);
const drawable = module.types.findByName(module.types.internString("Drawable")).?;
const circle = module.types.intern(.{ .@"struct" = .{ .name = module.types.internString("Circle"), .fields = &.{} } });
// Concrete struct → protocol value: erasure.
try std.testing.expectEqual(Plan.erase_protocol, cr.classify(circle, drawable));
}
test "conversions: classifyXX picks the xx-operator head decision" {
var arena = std.heap.ArenaAllocator.init(std.testing.allocator);
defer arena.deinit();
const alloc = arena.allocator();
var module = ir_mod.Module.init(alloc);
defer module.deinit();
var l = Lowering.init(&module);
const cr = CoercionResolver{ .l = &l };
const tt = &module.types;
const methods = [_]ast.ProtocolMethodDecl{protoMethodReq("draw")};
const pd = ast.ProtocolDecl{ .name = "Drawable", .methods = &methods };
l.registerProtocolDecl(&pd);
const drawable = tt.findByName(tt.internString("Drawable")).?;
// Any source unboxes regardless of dst.
try std.testing.expectEqual(XXPlan.unbox_any, cr.classifyXX(.any, .i64));
// Same type → no-op.
try std.testing.expectEqual(XXPlan.no_op, cr.classifyXX(.i64, .i64));
// dst is a protocol → erasure (checked before the src-protocol case).
try std.testing.expectEqual(XXPlan.erase_protocol, cr.classifyXX(.i64, drawable));
// src is a protocol, dst is a pointer → recover the ctx pointer.
try std.testing.expectEqual(XXPlan.protocol_to_pointer, cr.classifyXX(drawable, tt.ptrTo(.i64)));
// src is a protocol but dst is NOT a pointer → fall to the ladder.
try std.testing.expectEqual(XXPlan.coerce, cr.classifyXX(drawable, .i64));
// Pointer materialization (`xx value` into a `*T` slot, no built-in) defers
// to the ladder + the user-`Into` pointer fallback in lowerXX.
const a = tt.intern(.{ .@"struct" = .{ .name = tt.internString("A"), .fields = &.{} } });
try std.testing.expectEqual(XXPlan.coerce, cr.classifyXX(a, tt.ptrTo(.i32)));
}