5c1d00a877
Three pieces, no behavior change yet:
1. `ObjcPropertyKind` enum (strong/weak/copy/assign) + `objcPropertyKind`
helper in lower.zig. Reads `field.property_modifiers`, applies the
default rule (`*<ObjC-class>` → strong; primitives → assign), and
emits loud diagnostics for the silent-error budget:
- unknown modifier name (typo) → "expected one of: strong, weak, copy, ..."
- conflicting modifiers (e.g. `strong,weak`) → "mutually exclusive"
- `weak` on non-object slot → "requires a pointer-to-Obj-C-class type"
- `copy` on non-object slot → same
- `strong` (default or explicit) on `*void` → "ambiguous: specify
#property(strong|weak|copy|assign) explicitly"
Called from `emitObjcDefinedClassPropertyImps` for validation; the
returned kind isn't wired into setter/getter/dealloc yet — that's
the next three commits.
2. `ensureArcRuntimeDecls` lazily declares libobjc's ARC helpers:
objc_retain, objc_release, objc_storeWeak, objc_loadWeakRetained,
objc_initWeak, objc_destroyWeak. Uses the existing
`ensureCRuntimeDecl` pattern; idempotent.
3. Fix existing NSObject method names in std/objc.sx — `isEqual_`,
`isKindOfClass_`, `respondsToSelector_` had trailing underscores
that the selector mangling turned into double-colon selectors
(`isEqual::`). Removed the trailing underscore so the selectors
come out as `isEqual:`, `isKindOfClass:`, `respondsToSelector:`
as Apple's runtime expects.
4. Two xfail regression tests:
- ffi-objc-arc-02-strong-property: assigns child to parent's strong
property, releases the original child reference. Midpoint check:
child's dealloc should NOT have fired (strong setter retained).
Pre-M4.B-setter: child dealloc fires immediately → "FAIL: child
dealloc'd at midpoint" snapshot. Exit code 1.
- ffi-objc-arc-03-weak-property: assigns target to holder's weak
property, releases target. Reads holder.target → should be null
(auto-niled). Pre-M4.B-getter/setter: reads stale pointer →
"FAIL: weak property didn't auto-nil" snapshot.
These will turn green as M4.B setter (commit 2), getter (commit 3),
and dealloc-cleanup (commit 4) land. Each subsequent commit updates
the snapshot to reflect the now-passing output.
189/189 example tests pass; chess on iOS-sim green.
67 lines
2.1 KiB
Plaintext
67 lines
2.1 KiB
Plaintext
// ffi-objc-arc-03 — #property(weak) on sx-defined class.
|
|
//
|
|
// Weak contract:
|
|
// - setter calls objc_storeWeak — does NOT retain.
|
|
// - getter calls objc_loadWeakRetained + autorelease — auto-nils
|
|
// if the target has been deallocated.
|
|
// - -dealloc calls objc_destroyWeak on each weak ivar.
|
|
//
|
|
// Observation: assign a target to the weak property. Drop the
|
|
// caller's strong reference. Read back via the weak getter — should
|
|
// be `null` (the target deallocated when its last strong ref
|
|
// dropped, and the weak slot auto-niled).
|
|
//
|
|
// Pre-M4.B: setter just stores the pointer (no storeWeak); getter
|
|
// reads the raw pointer (no loadWeakRetained). After target's
|
|
// release, the slot points at freed memory — the read returns the
|
|
// stale pointer (not null). The test catches this by comparing the
|
|
// read result to null.
|
|
|
|
#import "modules/std.sx";
|
|
#import "modules/allocators.sx";
|
|
#import "modules/std/objc.sx";
|
|
#import "modules/compiler.sx";
|
|
|
|
SxWeakTarget :: #objc_class("SxWeakTarget") {
|
|
#extends NSObject;
|
|
tag: s32;
|
|
alloc :: () -> *SxWeakTarget;
|
|
}
|
|
|
|
SxWeakHolder :: #objc_class("SxWeakHolder") {
|
|
#extends NSObject;
|
|
target: *SxWeakTarget #property(weak);
|
|
alloc :: () -> *SxWeakHolder;
|
|
}
|
|
|
|
main :: () -> s32 {
|
|
inline if OS == .macos {
|
|
gpa := GPA.init();
|
|
tracker := TrackingAllocator.init(xx gpa);
|
|
|
|
push Context.{ allocator = xx tracker, data = null } {
|
|
holder := SxWeakHolder.alloc();
|
|
target := SxWeakTarget.alloc();
|
|
holder.target = target;
|
|
target.release();
|
|
|
|
// After release: target's refcount → 0 → target deallocates.
|
|
// With weak: holder.target should read as null (auto-niled).
|
|
// Without weak: holder.target reads as the stale pointer.
|
|
read_back := holder.target;
|
|
if read_back != null {
|
|
print("FAIL: weak property didn't auto-nil after target dealloc\n");
|
|
return 1;
|
|
}
|
|
|
|
holder.release();
|
|
}
|
|
|
|
print("weak property: ok\n");
|
|
}
|
|
inline if OS != .macos {
|
|
print("skipped (not macos)\n");
|
|
}
|
|
0;
|
|
}
|