The unary .not arm emitted bool_not (LLVM bitwise Not) for every
operand. Correct on i1; on an error binding — an error-set value, u32
tag at the LLVM level — a bitwise not of a nonzero tag stays nonzero,
so 'if !e' held even on a SET error and its branch read the
uninitialized success value (real segfault in the distribution repo's
sqlite tests). Plain integers had the same hole ('!7' was '~7').
Now: bool keeps bool_not; integers and error-set operands lower as the
truthiness complement (cmp_eq against a typed zero); anything else is
diagnosed instead of silently bit-flipped.
Regression: examples/1057 (set error: !e must not hold; success: !e
holds with a real value; integer truthiness) + examples/1171 (!"text"
diagnosed); both FAIL pre-fix. zig build test 426/426;
tests/run_examples.sh 600/600.
11 lines
291 B
Plaintext
11 lines
291 B
Plaintext
// `!` on an operand that has no truthiness (neither bool, integer, nor
|
|
// an error binding) is diagnosed instead of silently bit-flipped
|
|
// (issue 0129's diagnostic half).
|
|
#import "modules/std.sx";
|
|
|
|
main :: () -> i32 {
|
|
s := "text";
|
|
if !s { print("unreachable\n"); }
|
|
return 0;
|
|
}
|