6433eb6155
The reserved-type-name binding diagnostic fired correctly but underlined the enclosing statement / if / while / for / match / protocol / #objc_class block because every binding-name check reused the parent `node.span`. Thread each binding name's own span through the AST and parser, and pass it to `checkBindingNames`: - ast: add name spans to VarDecl, DestructureDecl, If/WhileExpr, ForExpr (capture + index), MatchArm, Catch/OnFailStmt, Protocol/ForeignMethodDecl. - parser: populate each span at the binding site from the name token's loc; destructure reuses each target identifier's own span. - semantic_diagnostics: every checkBindingName call now passes the binding's own span — no site falls back to node.span. fn/lambda params already used Param.name_span. Carets now land on the offending identifier itself. New regression examples/1125 asserts the protocol default-body and sx-defined #objc_class method param spans; 0125/1119-1124 expected updated to the precise carets.
36 lines
1.4 KiB
Plaintext
36 lines
1.4 KiB
Plaintext
error: 's2' is a reserved type name and cannot be used as an identifier
|
|
--> examples/1121-diagnostics-reserved-name-control-flow.sx:18:5
|
|
|
|
|
18 | s2, rest := pair(); // destructure name
|
|
| ^^
|
|
|
|
error: 'u8' is a reserved type name and cannot be used as an identifier
|
|
--> examples/1121-diagnostics-reserved-name-control-flow.sx:19:8
|
|
|
|
|
19 | if u8 := maybe() { } // if optional binding
|
|
| ^^
|
|
|
|
error: 's16' is a reserved type name and cannot be used as an identifier
|
|
--> examples/1121-diagnostics-reserved-name-control-flow.sx:20:11
|
|
|
|
|
20 | while s16 := maybe() { break; } // while optional binding
|
|
| ^^^
|
|
|
|
error: 'bool' is a reserved type name and cannot be used as an identifier
|
|
--> examples/1121-diagnostics-reserved-name-control-flow.sx:22:14
|
|
|
|
|
22 | for xs: (bool) { } // for capture name
|
|
| ^^^^
|
|
|
|
error: 's32' is a reserved type name and cannot be used as an identifier
|
|
--> examples/1121-diagnostics-reserved-name-control-flow.sx:23:17
|
|
|
|
|
23 | for xs: (v, s32) { } // for index name
|
|
| ^^^
|
|
|
|
error: 'string' is a reserved type name and cannot be used as an identifier
|
|
--> examples/1121-diagnostics-reserved-name-control-flow.sx:26:22
|
|
|
|
|
26 | case .some: (string) { 0 }
|
|
| ^^^^^^
|