The reserved-type-name binding diagnostic fired correctly but underlined the enclosing statement / if / while / for / match / protocol / #objc_class block because every binding-name check reused the parent `node.span`. Thread each binding name's own span through the AST and parser, and pass it to `checkBindingNames`: - ast: add name spans to VarDecl, DestructureDecl, If/WhileExpr, ForExpr (capture + index), MatchArm, Catch/OnFailStmt, Protocol/ForeignMethodDecl. - parser: populate each span at the binding site from the name token's loc; destructure reuses each target identifier's own span. - semantic_diagnostics: every checkBindingName call now passes the binding's own span — no site falls back to node.span. fn/lambda params already used Param.name_span. Carets now land on the offending identifier itself. New regression examples/1125 asserts the protocol default-body and sx-defined #objc_class method param spans; 0125/1119-1124 expected updated to the precise carets.
12 lines
455 B
Plaintext
12 lines
455 B
Plaintext
error: 'u8' is a reserved type name and cannot be used as an identifier
|
|
--> examples/1125-diagnostics-reserved-name-method-param.sx:15:28
|
|
|
|
|
15 | greet :: (self: *Self, u8: s64) -> s64 {
|
|
| ^^
|
|
|
|
error: 's16' is a reserved type name and cannot be used as an identifier
|
|
--> examples/1125-diagnostics-reserved-name-method-param.sx:23:27
|
|
|
|
|
23 | bump :: (self: *Self, s16: s32) {
|
|
| ^^^
|