camera: drop NSLog scaffolding now that macOS rotation is settled
The two `NSLog("[ux.camera] …")` calls were debug instrumentation for
diagnosing the macOS photo rotation issue. The bug is fixed
(macOS pinned to 0° rotation, photo + preview + video all 1280x720
landscape), so the NSLog calls are now stderr noise on every shot.
Keep the per-shot `diag(photo: WxH …)` emit since it goes through
`ux.Log` (gated by level, lands in banlu.jsonl) — useful if rotation
ever regresses on a different camera / macOS version, and the cost is
one log line per photo capture.
This commit is contained in:
@@ -1,7 +1,6 @@
|
|||||||
import AVFoundation
|
import AVFoundation
|
||||||
import Foundation
|
import Foundation
|
||||||
import ImageIO
|
import ImageIO
|
||||||
import os.log
|
|
||||||
|
|
||||||
/// Wraps `AVCapturePhotoOutput`. One instance per
|
/// Wraps `AVCapturePhotoOutput`. One instance per
|
||||||
/// [CameraInstance]; gets added to the session at create time and
|
/// [CameraInstance]; gets added to the session at create time and
|
||||||
@@ -112,13 +111,6 @@ private final class PhotoCaptureDelegate: NSObject, AVCapturePhotoCaptureDelegat
|
|||||||
didFinishProcessingPhoto photo: AVCapturePhoto,
|
didFinishProcessingPhoto photo: AVCapturePhoto,
|
||||||
error: Error?
|
error: Error?
|
||||||
) {
|
) {
|
||||||
// Belt-and-suspenders logging: the event-channel `diag` is the
|
|
||||||
// primary path (lands in `banlu.jsonl` via ux.Log), but NSLog
|
|
||||||
// is a fallback that ALWAYS lands in `flutter run` stderr +
|
|
||||||
// macOS Console regardless of channel state. Helps confirm
|
|
||||||
// whether the delegate is even firing when the jsonl shows
|
|
||||||
// nothing.
|
|
||||||
NSLog("[ux.camera] photoOutput callback fired error=\(error?.localizedDescription ?? "none")")
|
|
||||||
if let error = error as NSError? {
|
if let error = error as NSError? {
|
||||||
diag("photo capture failed: domain=\(error.domain)"
|
diag("photo capture failed: domain=\(error.domain)"
|
||||||
+ " code=\(error.code) desc=\(error.localizedDescription)")
|
+ " code=\(error.code) desc=\(error.localizedDescription)")
|
||||||
@@ -148,7 +140,6 @@ private final class PhotoCaptureDelegate: NSObject, AVCapturePhotoCaptureDelegat
|
|||||||
)))
|
)))
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
NSLog("[ux.camera] cgImage: %dx%d", cgImage.width, cgImage.height)
|
|
||||||
diag("photo: \(cgImage.width)x\(cgImage.height) " +
|
diag("photo: \(cgImage.width)x\(cgImage.height) " +
|
||||||
"(cgImageRepresentation, no EXIF)")
|
"(cgImageRepresentation, no EXIF)")
|
||||||
let destination = CGImageDestinationCreateWithURL(
|
let destination = CGImageDestinationCreateWithURL(
|
||||||
|
|||||||
Reference in New Issue
Block a user