Build strings through StringBuilder instead of chained concat #3

Closed

agra wants to merge 2 commits from string-builder-concat into master

agra commented

2026-09-18 17:12:13 +03:00

Owner

Tracker: #1635

Strings that grow in a loop or across several appends are built in one StringBuilder instead of chained concat, which copied the whole prefix on every link.

store.sx: patch_set, fts_quote, and_clause, placeholders are ufcs methods on *StringBuilder; the task/project UPDATE statements, the task filter, the FTS match and ORDER BY are each written into one builder.
api.sx: sse_data / sse_event are ufcs methods writing straight into the frame's builder; payload lines use the slice operator and slice_of is gone.
logging.sx: the request line is one builder; config is one variadic concat.

Output bytes are unchanged. Single fixed joins (concat("sak_", hex), concat(root, p)) stay as one concat call.

Verification at ea2bc64 on sx 6f334aa4: cold sx build src/main.sx -o sak ok; tests/*.sx 20 of 20, step9_release against dist/ packaged from ea2bc64.

Head: ea2bc64545

Tracker: [#1635](https://sak.swipelab.com/tasks/1635) Strings that grow in a loop or across several appends are built in one `StringBuilder` instead of chained `concat`, which copied the whole prefix on every link. - `store.sx`: `patch_set`, `fts_quote`, `and_clause`, `placeholders` are ufcs methods on `*StringBuilder`; the task/project `UPDATE` statements, the task filter, the FTS match and `ORDER BY` are each written into one builder. - `api.sx`: `sse_data` / `sse_event` are ufcs methods writing straight into the frame's builder; payload lines use the slice operator and `slice_of` is gone. - `logging.sx`: the request line is one builder; `config` is one variadic `concat`. Output bytes are unchanged. Single fixed joins (`concat("sak_", hex)`, `concat(root, p)`) stay as one `concat` call. Verification at ea2bc64 on sx 6f334aa4: cold `sx build src/main.sx -o sak` ok; `tests/*.sx` 20 of 20, `step9_release` against `dist/` packaged from ea2bc64. Head: ea2bc64545e41df53d131fe162d85415a69dec44

agra added 1 commit

2026-09-18 17:12:13 +03:00

Build SQL fragments, SSE frames and log lines through StringBuilder ea2bc64545

agra added 1 commit

2026-09-18 17:54:58 +03:00

test: grow request text through StringBuilder and flatten nested concat 8968b0034c

agra referenced this pull request

2026-10-07 17:21:58 +03:00

Build strings through StringBuilder instead of chained concat #44

agra commented

2026-10-07 17:22:03 +03:00

Author

Owner

Superseded by #44, which re-delivers this StringBuilder change on current master (sak task #1635, run contract comment 12565). Closing.

Superseded by https://git.swipelab.com/sx/sak/pulls/44, which re-delivers this StringBuilder change on current master (sak task #1635, run contract comment 12565). Closing.

agra closed this pull request

2026-10-07 17:22:03 +03:00

agra referenced this pull request

2026-10-27 04:33:20 +02:00

A run never moves its branch off the head the forge's branch holds, and a run whose push fails keeps its head on the forge #170

~~agra referenced this pull request 2026-10-27 15:30:03 +02:00~~

A backup of the live database runs beside sak's writes and never fails one #176

~~agra referenced this pull request 2026-10-30 05:35:58 +02:00~~

A slot acts on its launchd label or systemd unit only while the service manager holds that name from the slot's own file #188